-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CreditCardType is not accessible although it's used as a parameter to a public method #860
Comments
yes, that is not good |
Thanks for your reply! So we use creditCard() to generate valid PANs to use in the tests, now the generated PAN depends on the credit card type, e.g 16 digits for Mastercard and Visa but it's 15 digits for Amex. So we used to pass the credit card type to creditCard() to get a valid PAN for that specific type. |
I haven't checked yet, but does this affect both the 1.x and 2.x versions? |
It affects only 2.x versions |
I can release a 2.0.1 for this tomorrow. |
looks like only 2.x So far it could be considered as a WA |
Interesting: I'm sure I did that that change for a reason, I just don't remember what the reason was. I remember that I did it because all the classes in that package are Providers, except for CreditCardType. If I make the enum public, but keep it inside the Finance class, would that work for you? (I think the import will change a little, but that's it) |
The same issue seemed to affect Compass. I fixed both of them here: I'll merge them. After the merge, could you try out the 2.0.1-SNAPSHOT version? If that works well, I'll release it. |
Works for me 👍 |
Thanks for confirming. |
Thanks, I'll make a new release tomorrow! |
2.0.1 has been released, which should fix this issue. Thanks again for reporting and testing it! |
Describe the bug
CreditCardType enum has recently changed to be internal instead of external. This breaks any code that either uses the enum directly or the public method creditCard(CreditCardType creditCardType).
Expected behavior
CreditCardType be exposed to public.
The text was updated successfully, but these errors were encountered: