Repository navigation
provide planet specific data - #1052
Conversation
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
============================================
+ Coverage 92.18% 92.33% +0.14%
- Complexity 2762 2819 +57
============================================
Files 291 292 +1
Lines 5543 5607 +64
Branches 600 599 -1
============================================
+ Hits 5110 5177 +67
Misses 276 276
+ Partials 157 154 -3 ☔ View full report in Codecov by Sentry. |
|
I’d like to suggest keeping Pluto in the data and enum. By default you can exclude it, but providing a faker that accepts a boolean indicating its inclusion/exclusion would be a brilliant move in my opinion. Also you could include some kind of “classification” method…dwarf, rocky, gas, gas giant 🤷♂️ (I dunno if those actually all fall in the same category astronomically speaking but hopefully you get the vision 😉) |
|
Needs a spotlessapply but I forget the command off the top of my head. I'll try to get it for you later. You could try: |
|
it's written in logs
https://github.com/datafaker-net/datafaker/actions/runs/7465141979/job/20313659562?pr=1052#step:4:65 |
Definitely! This merge request is still a draft. I'll make it properly as soon as it's ready. Prior to that, I would prefer pushing here as regular till marked as non-draft. |
Thanks a lot for the idea! Agree that it makes sense to add that Neptune, besides there are a bunch of other planets What concerns being able to exclude - If I were a user then this Faker would rather over-complicate things. Public API present at the moment can get any info on a particular planet by its name. See - When it comes to the random faker - I would suggest skipping this part with exclusion and just adding these "non-planets" just like any other planet present out there. Still, user can decide what they want to get depending on their intentions. What do you think? |
|
Agreed. Keep the "full" list and users can always choose to ignore pluto etc in their own code. We can always re-visit in the future if there's feedback. |
|
Hi all, Apologies, I am extremely preoccupied with my full-time work-related matters and would like to take my free time for other things non-coding related. On this occasion, if you do consider that this improvement has some degree of priority then feel free to pick it up out of this point and move it forward. Thanks! Cheers! |
|
Hi @sergejsvisockis , no worries. I really like the work you've done here, and I don't want to let it go to waste, so let's keep the PR open if you don't mind, and one of us will complete the PR if you don't mind? |
Hi @bodiam, Sure, I am totally fine to keep it open till someone (including myself) can allocate time for this upon availability at any point in time in the future. |
|
Okay that should have spotless and tests dealt with. I'll loop back around to the pluto inclusion item in the next few |
|
From original commit: length_of_day:
pluto:
- "153 h"
mass:
pluto:
- "1.30900 × 1022 kg"
gravity:
pluto:
- "0.62 m/s²"
radius:
pluto:
- "1,188.3 km"
distance_from_sun:
pluto:
- "3.7 billion miles" |
|
Pluto added and good to go as far as I'm concerned. |
|
It looks good from the domain and implementation standpoint and as an initial author of this feature, I approve this Pull Request. |
|
Thanks @sergejsvisockis |
Thank you for finishing this one too! |
Mainly sourced from: - https://en.wikipedia.org/wiki/Pluto - https://en.wikipedia.org/wiki/List_of_gravitationally_rounded_objects_of_the_Solar_System Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
|
Fixed |
The following Pull Request contains planet-specific metadata.
Outdated method summary
The following methods are in place:
From @kingthorin:
Data seems to be sourced from: