Skip to content

Add medical professions in Medical faker - #1073

Merged
kingthorin merged 5 commits into
mainfrom
medical-professions
Jan 26, 2024
Merged

kingthorin merged 5 commits into
mainfrom
medical-professions

Conversation

@panilya

@panilya panilya commented Jan 26, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@what-the-diff

what-the-diff Bot commented Jan 26, 2024

Copy link
Copy Markdown

PR Summary

  • New Functionality Added in Medical Module
    A new operation called medicalProfession() was introduced in the Medical module. This operation is responsible for handling interactions related to medical professions.

  • Data List Addition
    A new data list medical_professions was included in the medical.yml file. This list consists of various categories related to medical field and roles.

  • Updated Test Case
    The testing method providerListTest() in MedicalTest was updated to include a new test for this added medicalProfession() function. This is to ensure the added feature works as expected before it's released.

@kingthorin kingthorin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any source info for this list?

@panilya

panilya commented Jan 26, 2024

Copy link
Copy Markdown
Collaborator Author

Just googled "medical professions". But I'm gonna add more medical professions from this Wikipedia list: https://en.wikipedia.org/wiki/List_of_healthcare_occupations

@panilya
panilya marked this pull request as draft January 26, 2024 18:28
@codecov-commenter

codecov-commenter commented Jan 26, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8a53eb) 92.36% compared to head (6c61f68) 92.31%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1073      +/-   ##
============================================
- Coverage     92.36%   92.31%   -0.06%     
+ Complexity     2821     2820       -1     
============================================
  Files           292      292              
  Lines          5608     5609       +1     
  Branches        599      599              
============================================
- Hits           5180     5178       -2     
- Misses          275      276       +1     
- Partials        153      155       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panilya
panilya marked this pull request as ready for review January 26, 2024 18:57
@panilya

panilya commented Jan 26, 2024

Copy link
Copy Markdown
Collaborator Author

Source: https://en.wikipedia.org/wiki/List_of_healthcare_occupations

@kingthorin kingthorin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kingthorin
kingthorin merged commit 38659da into main Jan 26, 2024
@kingthorin
kingthorin deleted the medical-professions branch January 26, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants