Skip to content

Conversation

@kingthorin
Copy link
Collaborator

@kingthorin kingthorin commented Feb 1, 2024

@what-the-diff
Copy link

what-the-diff bot commented Feb 1, 2024

PR Summary

  • Update to Random VPC ID Generation in AWS
    The code responsible for creating a random Virtual Private Cloud (VPC) ID in our AWS implementaion has been modified. More specifically, the way these IDs are generated has been changed to use a new method faker.random().hex(17, false). It creates a 17-character long, random hexadecimal number, providing a more efficient and reliable solution compared to the previous randHex() method.

  • Adjustments to VPC ID Testing Mechanism
    The checks done during our tests to verify the correctness of the VPC IDs have been updated to align with the aforementioned changes. The new pattern for VPC IDs, ^vpc-[0-9a-f]{17}$, is now in use in our testing suite, making sure we accurately validate these 17-character IDs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b37c566) 92.35% compared to head (1253d3b) 92.35%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1079   +/-   ##
=========================================
  Coverage     92.35%   92.35%           
- Complexity     2821     2822    +1     
=========================================
  Files           292      292           
  Lines          5609     5610    +1     
  Branches        599      599           
=========================================
+ Hits           5180     5181    +1     
  Misses          275      275           
  Partials        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin kingthorin force-pushed the aws-tweak branch 2 times, most recently from c48b883 to 8041e84 Compare February 1, 2024 17:28
@kingthorin kingthorin changed the title AWS vpc IDs now 17char AWS vpc/subnet/securitygroup IDs now 17char Feb 1, 2024
@kingthorin
Copy link
Collaborator Author

Tweaked

@kingthorin kingthorin merged commit b215fe0 into datafaker-net:main Feb 4, 2024
@kingthorin kingthorin deleted the aws-tweak branch February 4, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws().vpcId() generates invalid id

3 participants