Skip to content

Parent file could be null if resource is in jar #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snuyanzin merged 1 commit into from
Feb 29, 2024
Merged

Parent file could be null if resource is in jar #1101

snuyanzin merged 1 commit into from
Feb 29, 2024

Conversation

@snuyanzin
Copy link
Collaborator

@snuyanzin snuyanzin commented Feb 29, 2024

fixes #1099

@what-the-diff
Copy link

what-the-diff bot commented Feb 29, 2024

PR Summary

  • Introduction of Parent Directory Tracking in Locality.java
    The addLocaleIfPresent() method has been modified to include a new variable named parent. This addition allows for tracking the parent directory of any given file. This provides a better understanding of the file's location in the project structure.

@snuyanzin
Copy link
Collaborator Author

snuyanzin commented Feb 29, 2024

thanks for taking a look

@snuyanzin snuyanzin merged commit e72557e into datafaker-net:main Feb 29, 2024
@snuyanzin snuyanzin mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RVRhub RVRhub RVRhub approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'new Faker().locality().localeString()' throws java.lang.NullPointerException

2 participants

@snuyanzin @RVRhub