Skip to content

Add ISO 4217 numeric currency code faker in Currency faker group - #1111

Merged
bodiam merged 1 commit into
mainfrom
add-numeric-currency-code
Mar 3, 2024
Merged

Add ISO 4217 numeric currency code faker in Currency faker group#1111
bodiam merged 1 commit into
mainfrom
add-numeric-currency-code

Conversation

@panilya

@panilya panilya commented Mar 3, 2024

Copy link
Copy Markdown
Collaborator

@what-the-diff

what-the-diff Bot commented Mar 3, 2024

Copy link
Copy Markdown

PR Summary

  • New method addition in Currency class
    A new method named numericCode() has been integrated into the Currency class. This feature aims at providing an efficient way for handling numerical codes relevant to particular currencies.

  • Update in Currency Configuration
    The currency.yml file, used for setting up currency configurations, has been augmented with a numeric_code entry. This assists in the adaptation of the newly added method in the class and contributes to maintaining the consistency of the codebase.

  • Test Case for the New Method
    To ensure that the newly added numericCode() method functions as expected, a test case has been designed and can be found in the CurrencyTest class. This practice is crucial for improving the reliability of the overall system.

@panilya panilya changed the title Add numeric currency code faker in Currency faker group Add ISO 4217 numeric currency code faker in Currency faker group Mar 3, 2024
@bodiam

bodiam commented Mar 3, 2024

Copy link
Copy Markdown
Contributor

Nice! Thanks @panilya !

@bodiam
bodiam merged commit 77a048d into main Mar 3, 2024
@bodiam
bodiam deleted the add-numeric-currency-code branch March 3, 2024 21:41
@kingthorin

kingthorin commented Mar 3, 2024

Copy link
Copy Markdown
Collaborator

Before the next actual release you're going to need to do a find/replace in the code base to ensure things say the proper @SInCE version (2.1.1 or 2.2.0)

@bodiam

bodiam commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@kingthorin yeah, I saw that, that's fine. I'll probably remove all 2.1.1 references, and call it 2.2.0.

@kingthorin

Copy link
Copy Markdown
Collaborator

Great, just wanted to make sure it was on the radar 😁

@bodiam

bodiam commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@kingthorin it is. Doesn't mean I won't forget it though. I'll make a task for this!

@bodiam

bodiam commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@kingthorin #1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants