Deprecate fin tickers from Finace provider #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
============================================
+ Coverage 92.35% 92.41% +0.05%
- Complexity 2821 2837 +16
============================================
Files 292 293 +1
Lines 5609 5626 +17
Branches 599 599
============================================
+ Hits 5180 5199 +19
+ Misses 275 273 -2
Partials 154 154 ☔ View full report in Codecov by Sentry. |
bodiam
approved these changes
Mar 17, 2024
Contributor
bodiam
left a comment
bodiam
left a comment
There was a problem hiding this comment.
Great, looks good to me. Thanks for addressing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've deprecated the NSDQ, NYSE, and stock market methods (as suggested in #1128) in the Finance provider. Furthermore, I've added the stockMarket method (renaming it as 'exchanges') to the Stocks provider as it's more relevant to have it there.