Skip to content

Conversation

@k1w1dev
Copy link
Contributor

@k1w1dev k1w1dev commented Apr 13, 2024

resolves #1153

only knows about state and state_abbr. Fixing this with this commit.

Also improved NZ addresses in general.
@what-the-diff
Copy link

what-the-diff bot commented Apr 13, 2024

PR Summary

  • Extended en-NZ.yml with new properties
    The en-NZ.yml file, which is used to manage various application settings related to New Zealand's English locale, has been broadened with several new address-related properties. This enhancement will allow for more comprehensive manipulation and representation of addresses in New Zealand. Here's a quick rundown of the new properties:

    • address.full_address: Represents the full address.
    • address.country_code, address.state_abbr, address.state, address.city, address.suburb, address.postcode, address.building_number: Properties used to detail specific elements of an address.
    • address.rural_delivery_number,address.street_suffix,address.default_country,address.urban_address,address.rural_address,address.delivery_address,address.mail_box: Provide enhanced handling and representation for specific address types and conditions.
    • phone_number.area_code, phone_number.formats: Improves the handling of New Zealand specific phone number formats.

This thorough update will help add a layer of precision and context to the address handling for users accessing from New Zealand.

@k1w1dev k1w1dev marked this pull request as ready for review April 13, 2024 07:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (b37c566) to head (96fe788).
Report is 55 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1154      +/-   ##
============================================
+ Coverage     92.35%   92.42%   +0.07%     
- Complexity     2821     2836      +15     
============================================
  Files           292      293       +1     
  Lines          5609     5614       +5     
  Branches        599      598       -1     
============================================
+ Hits           5180     5189       +9     
+ Misses          275      271       -4     
  Partials        154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bodiam
Copy link
Contributor

bodiam commented Apr 14, 2024

Thanks for your contribution @k1w1dev , much appreciated! Looks good, merged!

@bodiam bodiam merged commit 4e5bf84 into datafaker-net:main Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix address for 'en-NZ' locale

3 participants