-
Notifications
You must be signed in to change notification settings - Fork 225
Add Greek translations for job provider #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
|
| - "Λιανεμπόριο" | ||
| - "Πωλήσεις" | ||
| - "Τεχνολογία" | ||
| seniority: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to translate these via Google or Deepl? (Maybe that'd help....or maybe some just don't make sense in Greek and should be trimmed?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I tried with Google Translate but the output was not what I expected for. I just tried all of them as an input in Deepl as well and it also left a lot of them untranslated.
To be honest, I treated the new el-GR.yml as a 1-1 translation for job.yml. Since the library is just a data "faker" and not a translation tool, you are right that I can trim the ones that do not fit.
There are still ones which are used mostly in their English variation (e.g. Lead, Senior, Junior, etc), so for these it seems more natural to be kept as is.
Thanks for the review and the tip @kingthorin ! I will come back later with the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file was updated.
The English terms are used to express seniority. I decided to not translate them because they will sound silly even in Greek context. 😄
Even words that were translated before they were removed as out of scope because they are not used to express seniority of a job in the Greek language.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
============================================
+ Coverage 92.35% 92.46% +0.11%
- Complexity 2821 2838 +17
============================================
Files 292 293 +1
Lines 5609 5614 +5
Branches 599 598 -1
============================================
+ Hits 5180 5191 +11
+ Misses 275 271 -4
+ Partials 154 152 -2 ☔ View full report in Codecov by Sentry. |
kingthorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
I would like to ask: is there a plan of when there will be a new release on maven central with latest changes? |
|
A snapshot version should already be available. The 2.2.0 plan is here: #1113 |
|
Hi @gvrettos , thanks for your contribution here! |
Hello there!
This is my first contribution to your nice project!
I have started using this library in one of the projects I work on and there was some gap I would like to contribute to.
I added the translations for the Greek language for the
jobprovider. Some words undersenioritysection were left untranslated because I could not find proper Greek words to replace them with. They can be used as is, though.Since this was the first bunch of translations for the Greek language, also README.md was updated accordingly.
Hoping that more Greek translations will follow. 😄