Skip to content

Conversation

@gvrettos
Copy link
Contributor

Hello there!

This is my first contribution to your nice project!
I have started using this library in one of the projects I work on and there was some gap I would like to contribute to.

I added the translations for the Greek language for the job provider. Some words under seniority section were left untranslated because I could not find proper Greek words to replace them with. They can be used as is, though.
Since this was the first bunch of translations for the Greek language, also README.md was updated accordingly.

Hoping that more Greek translations will follow. 😄

@what-the-diff
Copy link

what-the-diff bot commented Apr 14, 2024

PR Summary

  • Support for Greek Locale
    This PR includes the addition of the 'el-GR' locale to the list of supported locales. This means the software can now function efficiently in a Greek-speaking context.

  • Greek Translations Added
    A significant part of this PR is the addition of a new file 'el-GR.yml' that contains translations specific to the Greek locale. This includes terms for job fields, seniority levels, job positions, key skills, employment types, and education levels. Additionally, it establishes title patterns for job positions. This means the software can now generate job listings and communicate effectively in the Greek language.

- "Λιανεμπόριο"
- "Πωλήσεις"
- "Τεχνολογία"
seniority:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try to translate these via Google or Deepl? (Maybe that'd help....or maybe some just don't make sense in Greek and should be trimmed?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I tried with Google Translate but the output was not what I expected for. I just tried all of them as an input in Deepl as well and it also left a lot of them untranslated.

To be honest, I treated the new el-GR.yml as a 1-1 translation for job.yml. Since the library is just a data "faker" and not a translation tool, you are right that I can trim the ones that do not fit.
There are still ones which are used mostly in their English variation (e.g. Lead, Senior, Junior, etc), so for these it seems more natural to be kept as is.

Thanks for the review and the tip @kingthorin ! I will come back later with the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file was updated.
The English terms are used to express seniority. I decided to not translate them because they will sound silly even in Greek context. 😄
Even words that were translated before they were removed as out of scope because they are not used to express seniority of a job in the Greek language.

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.46%. Comparing base (b37c566) to head (d916a56).
Report is 56 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1156      +/-   ##
============================================
+ Coverage     92.35%   92.46%   +0.11%     
- Complexity     2821     2838      +17     
============================================
  Files           292      293       +1     
  Lines          5609     5614       +5     
  Branches        599      598       -1     
============================================
+ Hits           5180     5191      +11     
+ Misses          275      271       -4     
+ Partials        154      152       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kingthorin kingthorin merged commit ce7e5fe into datafaker-net:main Apr 14, 2024
@gvrettos gvrettos deleted the feature/job-el_GR branch April 14, 2024 18:43
@gvrettos
Copy link
Contributor Author

I would like to ask: is there a plan of when there will be a new release on maven central with latest changes?

@kingthorin
Copy link
Collaborator

A snapshot version should already be available.

The 2.2.0 plan is here: #1113

@bodiam
Copy link
Contributor

bodiam commented Apr 15, 2024

Hi @gvrettos , thanks for your contribution here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants