Adding a regexify test case for metacharacters inside a character set#1159
Merged
Conversation
snuyanzin
reviewed
Apr 16, 2024
| import java.util.Map; | ||
| import java.util.Random; | ||
| import java.util.Set; | ||
| import java.util.*; |
Collaborator
There was a problem hiding this comment.
please do not use import *
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
============================================
+ Coverage 92.35% 92.39% +0.04%
- Complexity 2821 2837 +16
============================================
Files 292 293 +1
Lines 5609 5614 +5
Branches 599 598 -1
============================================
+ Hits 5180 5187 +7
Misses 275 275
+ Partials 154 152 -2 ☔ View full report in Codecov by Sentry. |
Contributor
|
Thanks for adding this PR. Happy to accept it if you could please revert the |
Contributor
Author
|
Import changes reverted, thanks for the review! |
kingthorin
approved these changes
Apr 16, 2024
snuyanzin
approved these changes
Apr 16, 2024
Collaborator
|
Thanks for addressing feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1158