Skip to content

Adding a regexify test case for metacharacters inside a character set#1159

Merged
snuyanzin merged 1 commit into
datafaker-net:mainfrom
eduhoribe:main
Apr 16, 2024
Merged

Adding a regexify test case for metacharacters inside a character set#1159
snuyanzin merged 1 commit into
datafaker-net:mainfrom
eduhoribe:main

Conversation

@eduhoribe
Copy link
Copy Markdown
Contributor

Closes #1158

import java.util.Map;
import java.util.Random;
import java.util.Set;
import java.util.*;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not use import *

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.39%. Comparing base (b37c566) to head (cec79b9).
Report is 57 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1159      +/-   ##
============================================
+ Coverage     92.35%   92.39%   +0.04%     
- Complexity     2821     2837      +16     
============================================
  Files           292      293       +1     
  Lines          5609     5614       +5     
  Branches        599      598       -1     
============================================
+ Hits           5180     5187       +7     
  Misses          275      275              
+ Partials        154      152       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bodiam
Copy link
Copy Markdown
Contributor

bodiam commented Apr 16, 2024

Thanks for adding this PR. Happy to accept it if you could please revert the * import.

@eduhoribe
Copy link
Copy Markdown
Contributor Author

Import changes reverted, thanks for the review!

@snuyanzin
Copy link
Copy Markdown
Collaborator

Thanks for addressing feedback

@snuyanzin snuyanzin merged commit 0c9fbd3 into datafaker-net:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using metacharacters on a character set with regexify does not produce the expected text

5 participants