Skip to content

Conversation

@snuyanzin
Copy link
Collaborator

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Apr 25, 2024

PR Summary

  • Removal of <profile> block for jdk11+
    This PR includes removing a particular section in the project's configuration file which was meant for handling specific settings when the project was being run with JDK version 11 and above. This change implies that specific settings for different JDK versions are no longer necessary, possibly indicating enhancements in compatibility across different versions of the JDK (Java Development Kit).

@kingthorin
Copy link
Collaborator

I have nothing against this change, I don't know maven well enough. Should we just be changing this to 17+?

@snuyanzin
Copy link
Collaborator Author

it looks like anyway it became useless since all the tests are passing without these flags
Thus I do not see a reason to keep with jdk17 or 21

@snuyanzin snuyanzin merged commit d5561a7 into datafaker-net:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants