Skip to content

Conversation

@kingthorin
Copy link
Collaborator

@kingthorin kingthorin commented May 8, 2024

Most of these are just from brain storming.

Follow-up to: #1189

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.08%. Comparing base (b37c566) to head (972510e).
Report is 93 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1192      +/-   ##
============================================
- Coverage     92.35%   92.08%   -0.27%     
- Complexity     2821     2890      +69     
============================================
  Files           292      300       +8     
  Lines          5609     5726     +117     
  Branches        599      618      +19     
============================================
+ Hits           5180     5273      +93     
- Misses          275      293      +18     
- Partials        154      160       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bodiam
Copy link
Contributor

bodiam commented May 9, 2024

Looks great, let's merge!

@bodiam bodiam merged commit 4b48cfe into datafaker-net:main May 9, 2024
@kingthorin kingthorin deleted the more-loc branch May 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants