Skip to content

Conversation

@asolntsev
Copy link
Collaborator

  1. "et" is language code, and
  2. "ee" is country code

So the proper file name is "et.yml" (and optionally "et_EE.yml", "et_.yml" if needed to customize estonian language in other countries)

@what-the-diff
Copy link

what-the-diff bot commented May 23, 2024

PR Summary

  • Added Estonian Locale Support
    The README file has been updated to reflect the support of the new Estonian language locale.

  • Expanded Address Information in 'et.yml'
    More city names, street suffixes, and states are now available. Additional address related fields like city, street_name, and street_address have also been included. State abbreviations have also been updated for more diverse options.

  • Enriched Company Name Formats
    The company.name list in et.yml now comprises a wider variety of company name formats.

  • Enhanced Internet Data
    The internet.free_email list and internet.domain_suffix list in et.yml now have more options, offering more diverse choices for email providers and domain suffixes.

  • Extended Text Data
    The lorem.words list in et.yml has been expanded to include a wider pool of words.

  • Augmented Name Options
    The name lists in et.yml have been updated to include more options for female_first_name, male_first_name and last_name. Furthermore, the name_with_middle list now supports additional variations.

  • Updated Phone Number Formats
    Both the phone_number.formats and cell_phone.formats lists have been updated in the et.yml file to include more phone number and cell phone number formats. An additional formats_international section has been added for international phone number formats.

  • Introduced Invoice Section
    A new invoice section with a reference subsection has been added to provide patterns for invoice reference numbers.

@snuyanzin
Copy link
Collaborator

@asolntsev thanks for driving this
it seems PhoneNumberTest.phoneNumberInternational_estonia should be adopted since it is failing now

1. "et" is language code, and
2. "ee" is country code

So the proper file name is "et.yml" (and optionally "et_EE.yml", "et_<OTHER COUNTRY>.yml" if needed to customize estonian language in other countries)
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.13%. Comparing base (b37c566) to head (ad89983).
⚠️ Report is 822 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1206      +/-   ##
============================================
- Coverage     92.35%   92.13%   -0.22%     
- Complexity     2821     2904      +83     
============================================
  Files           292      301       +9     
  Lines          5609     5745     +136     
  Branches        599      620      +21     
============================================
+ Hits           5180     5293     +113     
- Misses          275      293      +18     
- Partials        154      159       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev
Copy link
Collaborator Author

@snuyanzin Oops, my bad. Fixed PhoneNumberTest.

@snuyanzin snuyanzin merged commit 06ebccc into datafaker-net:main May 24, 2024
@asolntsev asolntsev deleted the merge-estonian-files branch May 24, 2024 10:46
@asolntsev asolntsev self-assigned this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants