Skip to content

Conversation

@snuyanzin
Copy link
Collaborator

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented May 23, 2024

PR Summary

  • Renaming of COWMap.java to CopyOnWriteMap.java
    The file COWMap.java was renamed to CopyOnWriteMap.java to reflect the name of its functionality clearly and descriptively.

  • Switch from COWMap to CopyOnWriteMap in multiple files
    In both FakeResolver.java and FakeValuesService.java, several variables that were initially utilizing COWMap have been transitioned to use CopyOnWriteMap. This change promotes better transparency and comprehension of the code due to the more descriptive name, and might entail performance benefits due to the characteristics of CopyOnWrite data structures.

For reference, the affected variables are:

  • In FakeResolver.java: CLASS_2_FAKE_RESOLVER and DEFAULT_SCHEMA_CACHE
  • In FakeValuesService.java: fakeValuesInterfaceMap, CLASS_2_METHODS_CACHE, CLASS_2_CONSTRUCTOR_CACHE, expression2generex, key2Expression, ARGS_2_SPLITTED_ARGS, KEY_2_SPLITTED_KEY, key2fetchedObject, NAME_2_YAML, REMOVED_UNDERSCORE, MAP_OF_METHOD_AND_COERCED_ARGS, EXPRESSION_2_SPLITTED, and REGEXP2SUPPLIER_MAP.

These changes mainly increase the readability and consistency of the codebase, making it easier to understand and maintain.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (b37c566) to head (9461feb).
Report is 104 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1207      +/-   ##
============================================
- Coverage     92.35%   92.06%   -0.29%     
- Complexity     2821     2901      +80     
============================================
  Files           292      301       +9     
  Lines          5609     5745     +136     
  Branches        599      620      +21     
============================================
+ Hits           5180     5289     +109     
- Misses          275      294      +19     
- Partials        154      162       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few typos

@snuyanzin snuyanzin requested a review from asolntsev May 23, 2024 21:18
@kingthorin
Copy link
Collaborator

I have a few more tweaks coming for this one. Just need to get in front of a computer. It'll be a few more hours.

@kingthorin
Copy link
Collaborator

Sorry I didn't manage it this evening because a school thing went long. I'll tackle it in the morning.

It's just minor tweaks to the Java doc. I think I can do it as a suggestion and just apply it then approve and merge.

@snuyanzin
Copy link
Collaborator Author

Ok, will wait for your response @kingthorin
currently there is no rush
thanks for looking and willingness to improve it

@bodiam
Copy link
Contributor

bodiam commented May 24, 2024

@kingthorin @snuyanzin I'll just merge it for now, if it's doc improvements, feel free to send a new PR!

@bodiam bodiam merged commit 79f0e0d into datafaker-net:main May 24, 2024
@kingthorin
Copy link
Collaborator

Okay no worries. I'll send a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants