-
Notifications
You must be signed in to change notification settings - Fork 230
Rename COWMap to CopyOnWriteMap and add javadoc
#1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
For reference, the affected variables are:
These changes mainly increase the readability and consistency of the codebase, making it easier to understand and maintain. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
============================================
- Coverage 92.35% 92.06% -0.29%
- Complexity 2821 2901 +80
============================================
Files 292 301 +9
Lines 5609 5745 +136
Branches 599 620 +21
============================================
+ Hits 5180 5289 +109
- Misses 275 294 +19
- Partials 154 162 +8 ☔ View full report in Codecov by Sentry. |
asolntsev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few typos
src/main/java/net/datafaker/internal/helper/CopyOnWriteMap.java
Outdated
Show resolved
Hide resolved
src/main/java/net/datafaker/internal/helper/CopyOnWriteMap.java
Outdated
Show resolved
Hide resolved
|
I have a few more tweaks coming for this one. Just need to get in front of a computer. It'll be a few more hours. |
|
Sorry I didn't manage it this evening because a school thing went long. I'll tackle it in the morning. It's just minor tweaks to the Java doc. I think I can do it as a suggestion and just apply it then approve and merge. |
|
Ok, will wait for your response @kingthorin |
|
@kingthorin @snuyanzin I'll just merge it for now, if it's doc improvements, feel free to send a new PR! |
|
Okay no worries. I'll send a new one. |
No description provided.