Skip to content

Conversation

@snuyanzin
Copy link
Collaborator

@snuyanzin snuyanzin commented May 25, 2024

This should resolve #1215

also as example solves this for MD and CH

files for country codes should start with underscore

current order of handling using ro-MD as an example

  1. specific locale file ro-MD.yml
  2. language file ro.yml
  3. country file MD.yml
  4. default english locale en

Comment on lines +9 to +11
name:
male_first_name: [Александр, Алексей, Альберт, Анатолий, Андрей, Антон, Аркадий, Арсений, Артём, Борис, Вадим, Валентин, Валерий, Василий, Виктор, Виталий, Владимир, Владислав, Вячеслав, Геннадий, Георгий, Герман, Григорий, Даниил, Денис, Дмитрий, Евгений, Егор, Иван, Игнатий, Игорь, Илья, Константин, Лаврентий, Леонид, Лука, Макар, Максим, Матвей, Михаил, Никита, Николай, Олег, Роман, Семён, Сергей, Станислав, Степан, Фёдор, Эдуард, Юрий, Ярослав]
male_middle_name: [Александрович, Алексеевич, Альбертович, Анатольевич, Андреевич, Антонович, Аркадьевич, Арсеньевич, Артёмович, Борисович, Вадимович, Валентинович, Валерьевич, Васильевич, Викторович, Витальевич, Владимирович, Владиславович, Вячеславович, Геннадьевич, Георгиевич, Германович, Григорьевич, Даниилович, Денисович, Дмитриевич, Евгеньевич, Егорович, Иванович, Игнатьевич, Игоревич, Ильич, Константинович, Лаврентьевич, Леонидович, Лукич, Макарович, Максимович, Матвеевич, Михайлович, Никитич, Николаевич, Олегович, Романович, Семёнович, Сергеевич, Станиславович, Степанович, Фёдорович, Эдуардович, Юрьевич, Ярославович]
Copy link
Collaborator Author

@snuyanzin snuyanzin May 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied from ru.yml, so might be no 100% true

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.08%. Comparing base (b37c566) to head (9092817).
Report is 118 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1219      +/-   ##
============================================
- Coverage     92.35%   92.08%   -0.28%     
- Complexity     2821     2984     +163     
============================================
  Files           292      305      +13     
  Lines          5609     5872     +263     
  Branches        599      627      +28     
============================================
+ Hits           5180     5407     +227     
- Misses          275      306      +31     
- Partials        154      159       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bodiam bodiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@bodiam bodiam merged commit 5ccf7d9 into datafaker-net:main May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to specify country-specific setting, not language-specific?

3 participants