Minor tweaks and cleanup #1224
Merged
Minor tweaks and cleanup #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the previous few PRs and conversations. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1224 +/- ##
============================================
- Coverage 92.35% 92.12% -0.23%
- Complexity 2821 3000 +179
============================================
Files 292 306 +14
Lines 5609 5906 +297
Branches 599 628 +29
============================================
+ Hits 5180 5441 +261
- Misses 275 306 +31
- Partials 154 159 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asolntsev
approved these changes
May 27, 2024
bodiam
reviewed
May 28, 2024
|
|
||
| private static final int DEFAULT_MIN_AGE = 18; | ||
| private static final int DEFAULT_MAX_AGE = 65; | ||
| public static final int DEFAULT_MIN_AGE = 18; |
Contributor
There was a problem hiding this comment.
Probably package protected would be fine too?
Collaborator
Author
There was a problem hiding this comment.
Sure I'll adjust in another in the next few days
kingthorin
added a commit
to kingthorin/datafaker
that referenced
this pull request
May 28, 2024
Per: datafaker-net#1224 (comment) Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
bodiam
pushed a commit
that referenced
this pull request
May 28, 2024
Per: #1224 (comment) Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the previous few PRs and conversations.