[refactoring] extract phone numbers configuration to country-specific files #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files
The phone numbers do not depend on language. They depend only on country.
Both `new Locale("sq", "AL")` and `new Locale("en", "AL")` should generate Albanian phone numbers.
snuyanzin
approved these changes
May 31, 2024
Collaborator
snuyanzin
left a comment
snuyanzin
left a comment
There was a problem hiding this comment.
I have only superficial knowledge about phone number generation
so I don't see issues here and tests are green
LGTM from my side
asolntsev
deleted the
refactoring/extract-phone-setup-to-country-specific-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phone numbers do not depend on language. They depend only on country.
The motivation
Say, my goal is to generate an Albanian phone number.
I don't care about the language.
Both
new Locale("sq", "AL")andnew Locale("en", "AL")should generate Albanian phone numbers.The problem
But currently only
new Locale("sq", "AL")generates Albanian phone number, whilenew Locale("en", "AL")generate American phone number. Unexpected.P.S. Unfortunately, I didn't have enough time to refactor all countries, only part of them.