Drop deprecated Xml#1244
Merged
snuyanzin merged 1 commit intodatafaker-net:mainfrom Jun 1, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
============================================
- Coverage 92.35% 91.94% -0.41%
- Complexity 2821 3026 +205
============================================
Files 292 308 +16
Lines 5609 5922 +313
Branches 599 622 +23
============================================
+ Hits 5180 5445 +265
- Misses 275 319 +44
- Partials 154 158 +4 ☔ View full report in Codecov by Sentry. |
asolntsev
approved these changes
Jun 1, 2024
Collaborator
Author
|
Thanks for taking a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably a bit late however need to remove the latest old format approach for XML since it was also replaced by
XMLTransformer, no need for that anymore