Mark Internet#pass deprecated#1245
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1245 +/- ##
============================================
- Coverage 92.35% 92.03% -0.32%
- Complexity 2821 3042 +221
============================================
Files 292 309 +17
Lines 5609 5987 +378
Branches 599 629 +30
============================================
+ Hits 5180 5510 +330
- Misses 275 319 +44
- Partials 154 158 +4 ☔ View full report in Codecov by Sentry. |
kingthorin
left a comment
There was a problem hiding this comment.
Do we bundle unit tests in the library? It seems strange to document that users should check unit tests.
|
|
||
| /** | ||
| * Consider usage of {@link net.datafaker.providers.base.Text#text} instead, | ||
| * look at net.datafaker.providers.base.TextTest#textShouldContain3RULowerCaseAnd5CustomSpecialSymbols() |
There was a problem hiding this comment.
RULower? Regular upper lower?
There was a problem hiding this comment.
textShouldContain3RULowerCaseAnd5CustomSpecialSymbols
means that text should contain 3 lower case letters from RU locale and 5 custom special symbols
no
yep, there are 2 ways I see: either put example in javadoc for |
|
Ok, added to javadoc |
kingthorin
left a comment
There was a problem hiding this comment.
Thanks, I think that's much more usable
|
I've reverted this change. Without these methods it's way to complex too create a password, and I don't see why these methods can't exists next to each other. |
Internet#passwordis very limited with its functionality and we should encourage users to useTextinstead which covers much more cases