Skip to content

Conversation

@jensGiehl
Copy link
Contributor

Data taken from boardgamegeek.com and recommend.games

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be an Entertainment provider

@jensGiehl
Copy link
Contributor Author

This should probably be an Entertainment provider

For Entertainment, I wasn't sure if it belonged there, since only movies are listed there so far.

@jensGiehl jensGiehl force-pushed the main branch 3 times, most recently from 741c8eb to 37083d8 Compare June 5, 2024 22:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (b37c566) to head (c0ee818).
Report is 152 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1251      +/-   ##
============================================
- Coverage     92.35%   91.95%   -0.40%     
- Complexity     2821     3035     +214     
============================================
  Files           292      309      +17     
  Lines          5609     5932     +323     
  Branches        599      622      +23     
============================================
+ Hits           5180     5455     +275     
- Misses          275      319      +44     
- Partials        154      158       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bodiam
Copy link
Contributor

bodiam commented Jun 5, 2024

Hi @jensGiehl , thanks for this contribution! Looks great, and thanks for addressing the review comments!

@bodiam bodiam merged commit fae95fd into datafaker-net:main Jun 5, 2024
@kingthorin
Copy link
Collaborator

Geez you were quick. I read the comment about Entertainment and went and look, I almost told you that you merged to quickly and that there was already a Boardgame provider, then I realized the file I was looking at was only 2 minutes old 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants