fix flaky test: remove leasing "0" from generated phone number#1256
Merged
kingthorin merged 1 commit intomainfrom Jun 13, 2024
Merged
fix flaky test: remove leasing "0" from generated phone number#1256kingthorin merged 1 commit intomainfrom
kingthorin merged 1 commit intomainfrom
Conversation
the leading "0" makes the generated phone number an invalid in very rare cases in Argentina. For example, "011 1579-5896" was generated from AR pattern, but occurred to be invalid. P.S. And it seems that "0" is still needed in Italy and Hungary.
asolntsev
force-pushed
the
fix/flaky-test
branch
from
7e651db to
ac1f159
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the leading "0" makes the generated phone number an invalid in very rare cases in Argentina. For example, "011 1579-5896" was generated from AR pattern, but occurred to be invalid.
And it seems that "0" is still needed in Italy.