-
Notifications
You must be signed in to change notification settings - Fork 225
Implement generate stream for SQL transformer #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
|
# Conflicts: # src/test/java/net/datafaker/formats/SqlTest.java
|
@snuyanzin it's ready for review. This work is another critical item for my use-case with Spark. After this change I'll follow-up on this #1261 (comment) Thanks 🙏 |
|
@gatear This PR looks good to me, thank you for that, I think this should land in 2.3.0 Anyone else feedback? |
|
It looks okay to me, but I honestly haven't worked with or on the Transformers at all. |
src/main/java/net/datafaker/transformations/sql/SqlTransformer.java
Outdated
Show resolved
Hide resolved
|
lgtm, i left a minor comment |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
============================================
- Coverage 92.35% 91.92% -0.44%
- Complexity 2821 3090 +269
============================================
Files 292 310 +18
Lines 5609 6052 +443
Branches 599 636 +37
============================================
+ Hits 5180 5563 +383
- Misses 275 326 +51
- Partials 154 163 +9 ☔ View full report in Codecov by Sentry. |
snuyanzin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and addressing feedback
Generate a stream of SQL statements, support both singular and batch statements.