Skip to content

Conversation

@gatear
Copy link
Contributor

@gatear gatear commented Jun 26, 2024

Mention how complex types map from Faker schema to Spark types.

@what-the-diff
Copy link

what-the-diff bot commented Jun 26, 2024

PR Summary

  • Minor Grammatical Changes
    Some slight improvements have been made to the text in the code, making it more grammatically accurate.

  • Improvement in Formatting
    The structure of certain code segments has been enhanced for better readability and understanding.

  • Introduction of "Spark SQL" Section
    A new part has been added, entitled "Spark SQL". This explains our software's extended functionality for managing complex data types with Spark, a popular data processing engine.

  • Addition of Code Illustrations
    We have provided beneficial code examples in both Java and Kotlin languages to better illustrate the workings of the Spark SQL schema – a layout that defines how data is organized in Spark.

  • Inclusion of SQL Insert Statement
    For added clarity, we have depicted an expected SQL insert statement. This shows how data should ideally be added to our Spark SQL schema.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (b37c566) to head (a3474a3).
Report is 172 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1270      +/-   ##
============================================
- Coverage     92.35%   91.92%   -0.44%     
- Complexity     2821     3090     +269     
============================================
  Files           292      310      +18     
  Lines          5609     6052     +443     
  Branches        599      636      +37     
============================================
+ Hits           5180     5563     +383     
- Misses          275      326      +51     
- Partials        154      163       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

As with the previous PR I haven't used the transformers at all so I can't say if the details are technically correct.

@snuyanzin
Copy link
Collaborator

thanks for the contribution
I feel like at some point we have to have kind of compatibility matrix: what is supported for what dialect...
However it is a topic for a separate PR/issue

@snuyanzin snuyanzin merged commit 630ea90 into datafaker-net:main Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants