Skip to content

Conversation

@therepanic
Copy link
Contributor

All data was taken from open sources (like dota2.fandom.com).

There was already a dota.todo.yml concept, I changed the data and added the data in the afternoon, added a couple more methods to the new provider itself

@what-the-diff
Copy link

what-the-diff bot commented Jul 29, 2024

PR Summary

  • Addition of "Dota 2" to available providers
    The documentation has been updated to include "Dota 2" in the list of available video game providers. This notifies users about the newly added game support in our library.

  • Creation of a new 'Dota 2' class
    A new class specifically for handling elements from the "Dota 2" game has been added. This class handles various attributes of the game, making it easier for developers to work with these data points from "Dota 2".

  • Enhancement of the 'Video Game Providers' interface
    Integration has been improved by adding a method that allows retrieval of the "Dota 2" provider instance. This update enables a streamlined way to access the functionalities provided for "Dota 2".

  • Design of a test class for 'Dota 2'
    In order to ensure all the new additions work as intended, a test class has been added. This helps us reassure the stable and accurate implementation of the new "Dota 2" elements in our library.

kingthorin
kingthorin previously approved these changes Jul 29, 2024
Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kingthorin kingthorin dismissed their stale review July 29, 2024 21:40

Tests blew up

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (ecad040) to head (2234d3c).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1315      +/-   ##
============================================
- Coverage     91.82%   91.75%   -0.07%     
- Complexity     3086     3094       +8     
============================================
  Files           310      311       +1     
  Lines          6078     6090      +12     
  Branches        631      631              
============================================
+ Hits           5581     5588       +7     
- Misses          342      344       +2     
- Partials        155      158       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin
Copy link
Collaborator

I was going to suggest something like:

    @Test
    void dota2Quote() {
        // Given / When
        String quote = dota2.heroQuote(dota2.hero());
        // Then
        assertThat(quote).isNotEmpty();
    }

but it seems there aren't quotes for every hero. I guess you could make a list of those that do have quotes and then randomly pick from that Set for the test.

@therepanic
Copy link
Contributor Author

Also, in the future, when quotes are added for all heroes from the game itself, we should get rid of “availableHeroes” in Dota2Test itself and change the dota2HeroQuote test method to take heroes from dota2.hero().

@kingthorin
Copy link
Collaborator

@bodiam how sticky (or not) do you want to be about the codecov stuff?
image

@bodiam
Copy link
Contributor

bodiam commented Jul 30, 2024

@kingthorin not very, it was more indicative than anything else. I'm not sure why it breaks the build these days when the coverage goes down a bit, that wasn't intended.

@kingthorin
Copy link
Collaborator

Thanks. Merging as-is 🙂

@kingthorin kingthorin merged commit 9cfcfdf into datafaker-net:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants