Skip to content

Provides financial terms.#1319

Merged
bodiam merged 1 commit into
mainfrom
financial-terms
Aug 5, 2024
Merged

Provides financial terms.#1319
bodiam merged 1 commit into
mainfrom
financial-terms

Conversation

@bodiam

@bodiam bodiam commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

I needed something like this to create events, so now it can be used to generate this:

ExportLapseRequested
PolicyCardIssued
ReversalAlertCompleted
ATMCompletionExpired
AlertClaimUpdated
DeclineBreachIssued
AccessDeclinePending
ATMTransactionPending

@what-the-diff

what-the-diff Bot commented Aug 5, 2024

Copy link
Copy Markdown

PR Summary

  • Updated Configuration File
    The file maven.yml, which is kind of instruction set for our software building process, has been renamed to build.yml. This is just a simple naming change for clarity and doesn't affect the functionalities of the system.

  • Enhanced Data Generation Capabilities
    We have added a new feature that generates financial data. Specifically, there's a new method called financialTerms() in a file named BaseProviders.java, and this method helps to generate various financial terms.

  • New Module
    To support the above functionality, we have added a new file FinancialTerms.java under the net.datafaker.providers.base package.

  • Additional Resource
    We have supplemented a new resource file, called financial_terms.yml, in the en folder. This file contains a stockpile of financial terms that might be used by our feature.

  • Ensuring Quality
    To make sure that our new functionality works well, we have a new test file known as FinancialTermsTest.java under the net.datafaker.providers.base package. This test file ensures our FinancialTerms class works as per the expected norms.

@bodiam bodiam requested a review from kingthorin August 5, 2024 13:11
@codecov

codecov Bot commented Aug 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (9cfcfdf) to head (51e5b0f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1319      +/-   ##
============================================
+ Coverage     91.82%   92.00%   +0.17%     
- Complexity     3096     3114      +18     
============================================
  Files           311      313       +2     
  Lines          6090     6125      +35     
  Branches        631      629       -2     
============================================
+ Hits           5592     5635      +43     
+ Misses          342      332      -10     
- Partials        156      158       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin

Copy link
Copy Markdown
Collaborator

@kingthorin

Copy link
Copy Markdown
Collaborator

Other than that, it looks good to me.

@bodiam

bodiam commented Aug 5, 2024

Copy link
Copy Markdown
Contributor Author

Add it to the existing Finance provider?

I thought about it, but it's doing something very different, only the name is slightly similar. I'm not sure.

@bodiam bodiam merged commit a88cc1f into main Aug 5, 2024
@bodiam bodiam deleted the financial-terms branch August 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants