Refactoring: Relationship.any()

[asolntsev]

No description provided.

[what-the-diff]

PR Summary

• Introduction of Kind Enum in Relationship.java
  A new Kind enumeration is introduced with its corresponding values and expressions in Relationship.java file. This enhances the readability and maintainability of the code, as relationship expressions are now represented using this enum directly, making it easier to keep track of them.

• Modification in methods in Relationship.java
  The direct(), extended(), inLaw(), spouse(), parent(), and sibling() methods are altered to utilize the expressions from the Kind enum. This simplifies the way these methods operate and deliver values. The any() function also adapts to employing the Kind enum to pick a random relationship expression and resolve it to provide a value.

• Reset Mocks in RelationshipTest.java
  The beforeEach() method in the RelationshipTest.java file is updated to conduct a reset on the mockFaker and fakeValuesService mocks - ensuring that every test runs in a clean state.

• Updating Tests in RelationshipTest.java
  Certain exceptions are introduced in the test methods to check if the system behavior is reliable when faced with unexpected circumstances. The method anyWithIllegalArgumentExceptionThrown() is updated to throw an IllegalArgumentException during invocation of resolve(). Similarly, anyWithInvocationTargetExceptionThrown() is adapted to throw a NullPointerException during the same invocation. These changes help validate and improve the robustness of the application's exception handling mechanism.

• Modifying any() Method Handling in Test
  The any() method located in the test suite now throws the corresponding exceptions when resolve() is called on fakeValuesService. This helps ensure that the method operates robustly, even when faced with unexpected behaviors or exceptions. This ensures that the reliability and stability of the overall system are maintained.

[kingthorin]

Re: build failure
Run 'mvn spotless:apply' to fix these violations.

[asolntsev]

Re: build failure Run 'mvn spotless:apply' to fix these violations.

Oops, my bad :)
Fixed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (90b032a) to head (413b707).
Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1331      +/-   ##
============================================
+ Coverage     91.78%   91.87%   +0.08%     
+ Complexity     3160     3159       -1     
============================================
  Files           316      316              
  Lines          6236     6237       +1     
  Branches        634      634              
============================================
+ Hits           5724     5730       +6     
+ Misses          353      351       -2     
+ Partials        159      156       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kingthorin]

Thanks