-
Notifications
You must be signed in to change notification settings - Fork 225
simplify EnFile: don't collect a static list that is needed only once #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
============================================
+ Coverage 91.80% 91.82% +0.02%
Complexity 3157 3157
============================================
Files 316 316
Lines 6232 6229 -3
Branches 634 633 -1
============================================
- Hits 5721 5720 -1
+ Misses 353 351 -2
Partials 158 158 ☔ View full report in Codecov by Sentry. |
|
|
||
| // files where the search path can't be derived from the filename | ||
| private static final List<EnFile> FILES_WITH_A_DIFFERENT_PATH = Arrays.asList( | ||
| private static final List<EnFile> FILES_WITH_A_DIFFERENT_PATH = asList( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be immutable can't it? Being a CONSTANT certainly implies that's the case.
If so why not use List.of and not import anything from the Arrays package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kingthorin Good point. Done.
6b8c2a7 to
9021bc8
Compare
No description provided.