Skip to content

Conversation

@asolntsev
Copy link
Collaborator

No description provided.

@asolntsev asolntsev self-assigned this Aug 22, 2024
@what-the-diff
Copy link

what-the-diff bot commented Aug 22, 2024

PR Summary

  • Modification in SqlTransformer.java
    The SqlTransformer.java file underwent changes for a better and efficient code structure.

  • Refactoring of Interval class
    We transformed the private static class Interval into a private record Interval. This new structure now includes an add method enhancing its functionality.

  • Removal of getStart and getEnd Methods from Interval Record
    The getStart and getEnd methods were removed from the Interval record, streamlining its offerings.

  • Update on Method Calls
    The code has been updated to use start and end method calls, replacing the previous getStart and getEnd methods. This offers a more straightforward way of getting interval boundaries.

These changes make the code more efficient and maintainable, improving the overall application performance.

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't really done any work with records yet. This is a nice simplification.

@kingthorin kingthorin merged commit b5b1bdc into main Aug 22, 2024
@kingthorin kingthorin deleted the refactoring/convert-to-record branch August 22, 2024 20:14
@codecov
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (413b707) to head (df332cd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1333      +/-   ##
============================================
- Coverage     91.87%   91.75%   -0.12%     
+ Complexity     3159     3155       -4     
============================================
  Files           316      316              
  Lines          6237     6232       -5     
  Branches        634      634              
============================================
- Hits           5730     5718      -12     
- Misses          351      354       +3     
- Partials        156      160       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants