Skip to content

fix IDEA warnings#1337

Merged
asolntsev merged 5 commits into
mainfrom
refactor/fix-idea-warnings
Aug 24, 2024
Merged

fix IDEA warnings#1337
asolntsev merged 5 commits into
mainfrom
refactor/fix-idea-warnings

Conversation

@asolntsev

Copy link
Copy Markdown
Collaborator

No description provided.

@asolntsev asolntsev self-assigned this Aug 23, 2024
@what-the-diff

what-the-diff Bot commented Aug 23, 2024

Copy link
Copy Markdown

PR Summary

  • Detailed ID Number Generation for 'ChineseIdNumber.java'
    A new method named idNumber has been included, improving the functionality of the class by enabling it to generate valid ID numbers.

  • Efficient String Concatenation across multiple Java files
    The string concatenation method has been updated in Mbti.java, OscarMovie.java, and SqlTest.java. Now, + is used for concatenation which is a more common and intuitive way of combining strings, rather than the previous concat.

  • Expanded Features of 'OscarMovie.java'
    New methods by the name quote, character, and releaseDate are introduced in OscarMovie.java to augment the class's functionalities, permitting it to retrieve movie quotes, character info, and release dates.

  • Annotation Update in 'PolishIdNumberTest.java'
    Test annotations have been updated from @ParameterizedTest() to @ParameterizedTest, enhancing readability and maintaining code convention.

  • Important Import Additions in 'CompassTest.java'
    A crucial import statement has been added to CompassTest.java, which would help in better integration of pre-defined libraries.

  • Removing Unused Imports in 'WordTest.java'
    For code clarity and efficiency, unused import and static import statements in WordTest.java have been removed.

@codecov

codecov Bot commented Aug 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (197ac5f) to head (d9c1ce1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1337      +/-   ##
============================================
- Coverage     92.29%   92.13%   -0.16%     
+ Complexity     3145     3141       -4     
============================================
  Files           318      318              
  Lines          6189     6191       +2     
  Branches        612      612              
============================================
- Hits           5712     5704       -8     
- Misses          333      339       +6     
- Partials        144      148       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asolntsev asolntsev merged commit affd9ba into main Aug 24, 2024
@asolntsev asolntsev deleted the refactor/fix-idea-warnings branch August 24, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants