Skip to content

Add tier() and neutralItem() methods in Dota2 VideoGameProvider and update data#1342

Merged
kingthorin merged 2 commits into
datafaker-net:mainfrom
therepanic:main
Aug 28, 2024
Merged

Add tier() and neutralItem() methods in Dota2 VideoGameProvider and update data#1342
kingthorin merged 2 commits into
datafaker-net:mainfrom
therepanic:main

Conversation

@therepanic

Copy link
Copy Markdown
Contributor
  • Added tier() and neutralItem() methods in Dota2.class
  • Updated the data in dota2.yml
  • Updated the test for dota2HeroQuote()

@what-the-diff

what-the-diff Bot commented Aug 28, 2024

Copy link
Copy Markdown

PR Summary

  • Introduction of the method neutralItem()
    A new functionality called neutralItem() has been added to the Dota2.java file. This aims to provide a new aspect to the application by managing neutral items within Dota 2.

  • Implementation of the tier() method
    This pull request also involves the inclusion of a method called tier() in the Dota2.java file. This enhancement is designed to manage and categorize different tiers of items in Dota 2, hence making the game more organized.

  • Adjustments to Dota2Test.java file
    The Dota2Test.java file has been updated as well to incorporate the newly introduced neutralItem() and tier() methods in the test cases. This ensures that these changes are accurately tested, guaranteeing their proper functionality.

@codecov

codecov Bot commented Aug 28, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (2234d3c) to head (3c4f1a7).
Report is 72 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1342      +/-   ##
============================================
+ Coverage     91.75%   92.12%   +0.36%     
- Complexity     3094     3142      +48     
============================================
  Files           311      318       +7     
  Lines          6090     6193     +103     
  Branches        631      612      -19     
============================================
+ Hits           5588     5705     +117     
+ Misses          344      339       -5     
+ Partials        158      149       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/main/resources/en/dota2.yml Outdated
- "Muerta"
- "Naga Siren"
- "Nature's Prophet"
- "Natures Prophet"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure possessive was correct, not plural.

@therepanic therepanic Aug 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this because I wasn't sure if the tests would pass if the hero name in dota2.yml was spelled like this:

nature`s_prophet:
    quote:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay

@kingthorin kingthorin merged commit 00b0edd into datafaker-net:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants