Add tier() and neutralItem() methods in Dota2 VideoGameProvider and update data#1342
Conversation
therepanic
commented
Aug 28, 2024
- Added tier() and neutralItem() methods in Dota2.class
- Updated the data in dota2.yml
- Updated the test for dota2HeroQuote()
… dota2HeroQuote()
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1342 +/- ##
============================================
+ Coverage 91.75% 92.12% +0.36%
- Complexity 3094 3142 +48
============================================
Files 311 318 +7
Lines 6090 6193 +103
Branches 631 612 -19
============================================
+ Hits 5588 5705 +117
+ Misses 344 339 -5
+ Partials 158 149 -9 ☔ View full report in Codecov by Sentry. |
| - "Muerta" | ||
| - "Naga Siren" | ||
| - "Nature's Prophet" | ||
| - "Natures Prophet" |
There was a problem hiding this comment.
I'm pretty sure possessive was correct, not plural.
There was a problem hiding this comment.
I did this because I wasn't sure if the tests would pass if the hero name in dota2.yml was spelled like this:
nature`s_prophet:
quote: