Skip to content

#1343 search locales in all JAR files, not only in "datafaker*.jar"#1349

Merged
asolntsev merged 1 commit intomainfrom
fix/1343-scan-all-jars-for-locales
Sep 12, 2024
Merged

#1343 search locales in all JAR files, not only in "datafaker*.jar"#1349
asolntsev merged 1 commit intomainfrom
fix/1343-scan-all-jars-for-locales

Conversation

@asolntsev
Copy link
Collaborator

it may be needed in Spring Boot applications where datafaker*.jar is re-packaged into "spring*.jar" etc.

it may be needed in Spring Boot applications where datafaker*.jar is re-packaged into "spring*.jar" etc.
@asolntsev asolntsev self-assigned this Sep 10, 2024
@asolntsev asolntsev added the bug Something isn't working label Sep 10, 2024
@asolntsev asolntsev requested review from bodiam, kingthorin and panilya and removed request for panilya September 10, 2024 18:06
@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.33%. Comparing base (d465ec9) to head (cbeadc7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/net/datafaker/providers/base/Locality.java 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1349      +/-   ##
============================================
+ Coverage     92.24%   92.33%   +0.08%     
- Complexity     3147     3150       +3     
============================================
  Files           318      318              
  Lines          6193     6195       +2     
  Branches        612      612              
============================================
+ Hits           5713     5720       +7     
+ Misses          336      328       -8     
- Partials        144      147       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faker().locality().allSupportedLocales() returns empty when Datafaker is embedded in Spring Boot Uber JAR

1 participant