Skip to content

Conversation

@asolntsev
Copy link
Collaborator

@asolntsev asolntsev commented Sep 12, 2024

Now we don't scan classpath at all, but just return a hardcoded list of locales. Instead, we now have a unit-test that verifies that this list is up-to-date.

Related to:

Now we don't scan classpath at all, but just return a hardcoded list of locales.
Instead, we now have a unit-test that verifies that this list is up-to-date.
@codecov
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.42%. Comparing base (3e43689) to head (8d0424a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/net/datafaker/providers/base/Locality.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1350      +/-   ##
============================================
+ Coverage     92.23%   92.42%   +0.18%     
+ Complexity     3148     3142       -6     
============================================
  Files           318      318              
  Lines          6195     6162      -33     
  Branches        612      604       -8     
============================================
- Hits           5714     5695      -19     
+ Misses          332      325       -7     
+ Partials        149      142       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asolntsev asolntsev merged commit 2eb26bf into main Sep 12, 2024
@asolntsev asolntsev deleted the simplify/available-locales branch September 12, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants