Feature/greek philosophers el gr#1352
Conversation
|
I am not sure why the checks above failed. I had run it locally using maven and java 17 on Windows and there was no issue, 🤔 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
============================================
- Coverage 92.37% 92.35% -0.02%
- Complexity 3140 3141 +1
============================================
Files 318 318
Lines 6162 6162
Branches 604 604
============================================
- Hits 5692 5691 -1
- Misses 326 329 +3
+ Partials 144 142 -2 ☔ View full report in Codecov by Sentry. |
I think it's only the code coverage check failing, which always fails. I'll try to disable or fix it, it's a bit misleading. And thanks for your PR, we really like them, even when they're less sophisticated :) |
|
It was actually CI that was failing but I re-ran failed jobs and it passed on the second go |
Not something very sophisticated here.
I just added some
el_GRvalues forGreekPhilosopherprovider.