Skip to content

Feature/greek philosophers el gr#1352

Merged
bodiam merged 2 commits intodatafaker-net:mainfrom
gvrettos:feature/greek-philosophers-el_GR
Sep 15, 2024
Merged

Feature/greek philosophers el gr#1352
bodiam merged 2 commits intodatafaker-net:mainfrom
gvrettos:feature/greek-philosophers-el_GR

Conversation

@gvrettos
Copy link
Copy Markdown
Contributor

Not something very sophisticated here.
I just added some el_GR values for GreekPhilosopher provider.

@gvrettos
Copy link
Copy Markdown
Contributor Author

I am not sure why the checks above failed. I had run it locally using maven and java 17 on Windows and there was no issue, 🤔

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (79f0bfd) to head (5d5c885).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1352      +/-   ##
============================================
- Coverage     92.37%   92.35%   -0.02%     
- Complexity     3140     3141       +1     
============================================
  Files           318      318              
  Lines          6162     6162              
  Branches        604      604              
============================================
- Hits           5692     5691       -1     
- Misses          326      329       +3     
+ Partials        144      142       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bodiam
Copy link
Copy Markdown
Contributor

bodiam commented Sep 15, 2024

I am not sure why the checks above failed. I had run it locally using maven and java 17 on Windows and there was no issue, 🤔

I think it's only the code coverage check failing, which always fails. I'll try to disable or fix it, it's a bit misleading.

And thanks for your PR, we really like them, even when they're less sophisticated :)

@bodiam bodiam merged commit 9e8cfd5 into datafaker-net:main Sep 15, 2024
@gvrettos gvrettos deleted the feature/greek-philosophers-el_GR branch September 15, 2024 08:54
@kingthorin
Copy link
Copy Markdown
Collaborator

It was actually CI that was failing but I re-ran failed jobs and it passed on the second go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants