Skip to content

fix: the last digit of ChineseIdNumber#1354

Merged
kingthorin merged 1 commit into
datafaker-net:mainfrom
ly1012:main
Sep 18, 2024
Merged

fix: the last digit of ChineseIdNumber#1354
kingthorin merged 1 commit into
datafaker-net:mainfrom
ly1012:main

Conversation

@ly1012

@ly1012 ly1012 commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

Fix #1353 bug.

@asolntsev asolntsev added the bug Something isn't working label Sep 18, 2024

@asolntsev asolntsev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Sep 18, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (9e8cfd5) to head (3f4e943).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1354      +/-   ##
============================================
- Coverage     92.43%   92.42%   -0.02%     
- Complexity     3141     3143       +2     
============================================
  Files           318      318              
  Lines          6162     6162              
  Branches        604      604              
============================================
- Hits           5696     5695       -1     
- Misses          323      327       +4     
+ Partials        143      140       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin kingthorin merged commit f7b194b into datafaker-net:main Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChineseIdNumber: Last digit is wrong

3 participants