Skip to content

Conversation

@ksy-ke
Copy link
Contributor

@ksy-ke ksy-ke commented Sep 23, 2024

Hello!

This is my first contribution to open source, hope I do everything right.

There is nothing special, just new Id generator

@what-the-diff
Copy link

what-the-diff bot commented Sep 23, 2024

PR Summary

  • Introduced Ukrainian Identity Number Generation
    The addition of the 'UkrainianIdNumber' class provides the capability to generate Ukrainian Identity Numbers, also known as UNZR. This feature includes methods for creating both valid and invalid identity numbers, facilitating various testing requirements.

  • Configuration Update to include new Identity Generator
    The system's configuration file has been revised to include the 'UkrainianIdNumber' under the existing 'IdNumberGenerator' interface, integrating it into the overall ID generation system.

  • Validations through Testing
    A new test class 'UkrainianIdNumberTest' has been created to verify the reliability and correctness of the new ID generation process. It ensures that the system can generate and correctly handle both valid and invalid UNZR formats.

  • Expansion of General ID Test for Ukrainian Format
    Existing tests under 'IdNumberTest' have been expanded to encompass the Ukrainian UNZR format. These tests use regex patterns to confirm that both valid and invalid UNZR formats are recognized properly.

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.32%. Comparing base (9e8cfd5) to head (38fc8fd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1357      +/-   ##
============================================
- Coverage     92.43%   92.32%   -0.12%     
- Complexity     3141     3143       +2     
============================================
  Files           318      319       +1     
  Lines          6162     6177      +15     
  Branches        604      604              
============================================
+ Hits           5696     5703       +7     
- Misses          323      329       +6     
- Partials        143      145       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asolntsev asolntsev merged commit e40e8b0 into datafaker-net:main Sep 23, 2024
11 of 12 checks passed
@asolntsev
Copy link
Collaborator

@ksy-ke Thank you for the contribution!
Yes, everything is allright :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants