fix: University tests#1411
Conversation
PR Summary
|
asolntsev
left a comment
There was a problem hiding this comment.
- Why it's needed to ignore file "test.txt"? I don't see any tests that would create such a file.
- This regex is not enough. UniversityTest still can fail:
java.lang.AssertionError:
Expecting actual:
"North Leffler Academy of Aix-Marseille"
to match pattern:
"[A-Za-z'() öèü]+"|
Oops thanks, I didn’t account for hyphen or other chars, I had searched non-ASCII. I’ll dig into the test.txt thing, maybe it was something I’d polluted the repo with somehow. |
Extended the expected regex to include a few characters with accents. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
deb6710 to
f1f0db1
Compare
|
@asolntsev fixed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
============================================
+ Coverage 92.21% 92.25% +0.04%
- Complexity 3149 3151 +2
============================================
Files 319 319
Lines 6149 6149
Branches 591 591
============================================
+ Hits 5670 5673 +3
+ Misses 334 333 -1
+ Partials 145 143 -2 ☔ View full report in Codecov by Sentry. |
Extended the expected regex to include a few characters with accents.
Addresses #1404 (comment)
Add recently introduced test artifacttest.txtto.gitignoreFYI if anyone needs to run single UnitTest classes or methods locally you can use:
./mvnw test -Dtest=UniversityTest./mvnw test -Dtest=UniversityTest#testNamesyntax.