Feature: new methods nextInt(Range) and nextLong(Range)#1416
Merged
kingthorin merged 2 commits intomainfrom Oct 31, 2024
Merged
Feature: new methods nextInt(Range) and nextLong(Range)#1416kingthorin merged 2 commits intomainfrom
nextInt(Range) and nextLong(Range)#1416kingthorin merged 2 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1416 +/- ##
============================================
+ Coverage 92.21% 92.30% +0.09%
- Complexity 3149 3168 +19
============================================
Files 319 320 +1
Lines 6149 6173 +24
Branches 591 592 +1
============================================
+ Hits 5670 5698 +28
+ Misses 334 333 -1
+ Partials 145 142 -3 ☔ View full report in Codecov by Sentry. |
978ddb6 to
6531ed3
Compare
6531ed3 to
ec609be
Compare
to define explicitly if the min/max should be inclusive or exclusive
there is no point to call `randomNumber(strict = false)`. It's the same as just `faker.random().nextLong()`.
ec609be to
47a9d0c
Compare
kingthorin
approved these changes
Oct 31, 2024
Collaborator
kingthorin
left a comment
There was a problem hiding this comment.
I wish it followed Java naming standards but it isn't worth arguing about. Nice work!
Contributor
|
I like it! Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does the API look good?
I mean, these names are quite long (but explicit):