Skip to content

Conversation

@asolntsev
Copy link
Collaborator

@asolntsev asolntsev commented Oct 31, 2024

remove occasional spaces from Greek names

Example of test failure:

java.lang.AssertionError:
Expecting actual: "Ευστάθιος "
to match pattern: "\p{L}+"

at net.datafaker.providers.base.NameTest$NameInGreekTest.testMaleFirstName(NameTest.java:134)

See https://github.com/datafaker-net/datafaker/actions/runs/11604541542

remove occasional spaces from Greek names

Example of test failure:
```
java.lang.AssertionError:
Expecting actual: "Ευστάθιος "
to match pattern: "\p{L}+"

at net.datafaker.providers.base.NameTest$NameInGreekTest.testMaleFirstName(NameTest.java:134)
```
@asolntsev asolntsev self-assigned this Oct 31, 2024
@asolntsev asolntsev added the bug Something isn't working label Oct 31, 2024
@what-the-diff
Copy link

what-the-diff bot commented Oct 31, 2024

PR Summary

  • Correction of Trailing Spaces in Names
    This update enhances data cleanliness and accuracy in the Greek language version of the software. Several names had extra spaces at the end, which have now been removed improving display of these names and possibly avoiding potential errors. The changes are listed below:

    • From "Απόστολος " to "Απόστολος"
    • From "Δήμας " to "Δήμας"
    • From "Ειρηναίος " to "Ειρηναίος"
    • From "Έλενος " to "Έλενος"
    • From "Ευστάθιος " to "Ευστάθιος"
    • From "Κολιός " to "Κολιός"
    • From "Λιάκος " to "Λιάκος"
    • From "Τρύφων " to "Τρύφων"

@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (d00cb0d) to head (3dec232).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1417   +/-   ##
=========================================
  Coverage     92.17%   92.17%           
  Complexity     3148     3148           
=========================================
  Files           319      319           
  Lines          6149     6149           
  Branches        591      591           
=========================================
  Hits           5668     5668           
- Misses          335      336    +1     
+ Partials        146      145    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asolntsev asolntsev merged commit 832116d into main Oct 31, 2024
@asolntsev asolntsev deleted the fix/flaky-test-with-greek-names branch October 31, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant