Refactor few tests#1418
Conversation
IDEA showed warnings about multiple tests that didn't contain any asserts.
+ occasionally, simplify the test itself :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
============================================
- Coverage 92.32% 92.25% -0.07%
+ Complexity 3153 3151 -2
============================================
Files 319 319
Lines 6149 6149
Branches 591 591
============================================
- Hits 5677 5673 -4
- Misses 331 333 +2
- Partials 141 143 +2 ☔ View full report in Codecov by Sentry. |
| /** | ||
| * @author pmiklos | ||
| */ | ||
| @SuppressWarnings("removal") |
There was a problem hiding this comment.
If something here is deprecated for removal why not address the issue now instead of waiting for it to fail in the future?
There was a problem hiding this comment.
The deprecated class is DataFaker's own class DateAndTime.java.
And this DateAndTimeTest.java is the test for this deprecated class. :)
We still need this test until we finally delete both files.
There was a problem hiding this comment.
Oh okay, I thought it was something in the Java base. Thanks for clarifying.
2 participants
No description provided.