Skip to content

Add greek values for Football provider#1428

Merged
kingthorin merged 1 commit intodatafaker-net:mainfrom
gvrettos:feature/football-el_GR
Nov 3, 2024
Merged

Add greek values for Football provider#1428
kingthorin merged 1 commit intodatafaker-net:mainfrom
gvrettos:feature/football-el_GR

Conversation

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (8c61c5b) to head (b299646).
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1428      +/-   ##
============================================
+ Coverage     92.19%   92.21%   +0.01%     
- Complexity     3161     3162       +1     
============================================
  Files           320      320              
  Lines          6178     6178              
  Branches        592      592              
============================================
+ Hits           5696     5697       +1     
+ Misses          340      339       -1     
  Partials        142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin kingthorin merged commit c82724c into datafaker-net:main Nov 3, 2024
@bodiam
Copy link
Contributor

bodiam commented Nov 3, 2024

@GVretto thanks for this. Would it help you if we add the oktober fest label on this?

@gvrettos gvrettos deleted the feature/football-el_GR branch November 3, 2024 11:44
@gvrettos
Copy link
Contributor Author

gvrettos commented Nov 3, 2024

@GVretto thanks for this. Would it help you if we add the oktober fest label on this?

Hello @bodiam. No, it is not necessary to add the label since the the fest is over. Thank you though for mentioning. Maybe next year again. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants