Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to pass seed to FakeValuesService #222

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

snuyanzin
Copy link
Collaborator

The PR allows to pass seed within doWith
now it's possible to pass seed like

faker.doWith(() -> faker.name().firstName(), 123);

or both seed and locale

faker.doWith(() -> faker.name().firstName(), Locale.GERMAN, 123);

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #222 (18d5dfc) into master (64d6054) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #222      +/-   ##
============================================
+ Coverage     94.33%   94.37%   +0.03%     
- Complexity     1879     1882       +3     
============================================
  Files           195      195              
  Lines          3797     3819      +22     
  Branches        391      391              
============================================
+ Hits           3582     3604      +22     
  Misses          115      115              
  Partials        100      100              
Impacted Files Coverage Δ
src/main/java/net/datafaker/Faker.java 98.31% <100.00%> (+0.12%) ⬆️
.../java/net/datafaker/service/FakeValuesService.java 88.12% <100.00%> (+0.12%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@snuyanzin snuyanzin merged commit 18d5dfc into datafaker-net:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants