Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Computer' faker #261

Merged
merged 4 commits into from
Jul 30, 2022
Merged

Add 'Computer' faker #261

merged 4 commits into from
Jul 30, 2022

Conversation

panilya
Copy link
Collaborator

@panilya panilya commented Jul 29, 2022

No description provided.

@panilya panilya changed the title Computer faker Add computer faker Jul 29, 2022
@panilya panilya changed the title Add computer faker Add 'Computer' faker Jul 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #261 (f2a124d) into master (8d79655) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
+ Coverage     94.62%   94.67%   +0.04%     
- Complexity     1879     1887       +8     
============================================
  Files           192      193       +1     
  Lines          3945     3959      +14     
  Branches        393      393              
============================================
+ Hits           3733     3748      +15     
+ Misses          111      110       -1     
  Partials        101      101              
Impacted Files Coverage Δ
.../main/java/net/datafaker/service/files/EnFile.java 93.33% <ø> (ø)
src/main/java/net/datafaker/Computer.java 100.00% <100.00%> (ø)
src/main/java/net/datafaker/Faker.java 98.18% <100.00%> (+<0.01%) ⬆️
src/main/java/net/datafaker/Hearthstone.java 92.30% <0.00%> (-7.70%) ⬇️
src/main/java/net/datafaker/Address.java 94.44% <0.00%> (ø)
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 96.29% <0.00%> (+3.70%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bodiam
Copy link
Contributor

bodiam commented Jul 30, 2022

Nice one!! Thanks!

@bodiam bodiam closed this Jul 30, 2022
@bodiam bodiam reopened this Jul 30, 2022
@bodiam bodiam merged commit 0f4f0f9 into datafaker-net:master Jul 30, 2022
@bodiam
Copy link
Contributor

bodiam commented Jul 30, 2022

(Sorry, I pressed the wrong button!)

@panilya panilya deleted the computer-faker branch July 30, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants