Introduce AbstractProvider#262
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
============================================
- Coverage 94.69% 94.33% -0.36%
- Complexity 1888 1889 +1
============================================
Files 193 194 +1
Lines 3955 3795 -160
Branches 393 393
============================================
- Hits 3745 3580 -165
- Misses 110 114 +4
- Partials 100 101 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 issues:
The PR introduces an
AbstractProviderand makes use it by all providers. Also it allows to create and use custom providers without creation custom fakers, for more details have a look atnet.datafaker.CustomFakerTest#insectBeeTestExpressionFromFileWithoutExtraFaker