Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce AbstractProvider #262

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Introduce AbstractProvider #262

merged 1 commit into from
Jul 31, 2022

Conversation

snuyanzin
Copy link
Collaborator

There are 2 issues:

  1. currently to create and use your own provider it is required to create a custom faker
  2. each time a new provider should contain a faker (minor issue but annoying)

The PR introduces an AbstractProvider and makes use it by all providers. Also it allows to create and use custom providers without creation custom fakers, for more details have a look at net.datafaker.CustomFakerTest#insectBeeTestExpressionFromFileWithoutExtraFaker

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #262 (89743e7) into master (ff9bf48) will decrease coverage by 0.35%.
The diff coverage is 99.66%.

@@             Coverage Diff              @@
##             master     #262      +/-   ##
============================================
- Coverage     94.69%   94.33%   -0.36%     
- Complexity     1888     1889       +1     
============================================
  Files           193      194       +1     
  Lines          3955     3795     -160     
  Branches        393      393              
============================================
- Hits           3745     3580     -165     
- Misses          110      114       +4     
- Partials        100      101       +1     
Impacted Files Coverage Δ
...main/java/net/datafaker/idnumbers/PeselNumber.java 100.00% <ø> (ø)
...ava/net/datafaker/HitchhikersGuideToTheGalaxy.java 88.88% <87.50%> (-1.12%) ⬇️
src/main/java/net/datafaker/Address.java 94.28% <95.65%> (-0.16%) ⬇️
src/main/java/net/datafaker/AbstractProvider.java 100.00% <100.00%> (ø)
src/main/java/net/datafaker/Ancient.java 100.00% <100.00%> (ø)
src/main/java/net/datafaker/Animal.java 100.00% <100.00%> (ø)
src/main/java/net/datafaker/App.java 100.00% <100.00%> (ø)
src/main/java/net/datafaker/Appliance.java 100.00% <100.00%> (ø)
...c/main/java/net/datafaker/AquaTeenHungerForce.java 100.00% <100.00%> (ø)
src/main/java/net/datafaker/Artist.java 100.00% <100.00%> (ø)
... and 327 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants