Skip to content

Add space between providers' names #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

panilya
Copy link
Collaborator

@panilya panilya commented Jul 30, 2022

I noticed that in the README some providers' names have spaces and some don't, so I corrected them to more readable ones.

@panilya panilya requested review from bodiam and snuyanzin July 30, 2022 18:28
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #264 (e522c44) into master (0f4f0f9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #264   +/-   ##
=========================================
  Coverage     94.69%   94.69%           
  Complexity     1888     1888           
=========================================
  Files           193      193           
  Lines          3955     3955           
  Branches        393      393           
=========================================
  Hits           3745     3745           
  Misses          110      110           
  Partials        100      100           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bodiam
Copy link
Contributor

bodiam commented Jul 31, 2022

Nice! What we actually need is a small tool to regenerate this list automatically, and also ideally create the providers.md file, which I think is getting a bit out of date, since it's quite tricky to update it every time

@bodiam bodiam merged commit ff9bf48 into datafaker-net:master Jul 31, 2022
@panilya panilya deleted the readme-fakers-fix branch July 31, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants