Skip to content

Allow tests running concurrently#267

Merged
snuyanzin merged 1 commit into
datafaker-net:masterfrom
snuyanzin:test_conc
Aug 1, 2022
Merged

Allow tests running concurrently#267
snuyanzin merged 1 commit into
datafaker-net:masterfrom
snuyanzin:test_conc

Conversation

@snuyanzin

@snuyanzin snuyanzin commented Jul 31, 2022

Copy link
Copy Markdown
Collaborator

The PR allows tests running concurrently and fixes some issued during concurrent running
this should fix #256

@codecov-commenter

codecov-commenter commented Jul 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #267 (063e7fe) into master (18d5dfc) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #267      +/-   ##
============================================
- Coverage     94.37%   94.26%   -0.11%     
+ Complexity     1883     1881       -2     
============================================
  Files           195      195              
  Lines          3819     3819              
  Branches        391      391              
============================================
- Hits           3604     3600       -4     
- Misses          115      117       +2     
- Partials        100      102       +2     
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.32% <100.00%> (-0.81%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Comment thread src/test/java/net/datafaker/service/FakeValuesServiceTest.java Outdated
@snuyanzin
snuyanzin merged commit 94d9955 into datafaker-net:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConcurrentModificationException when using parallel test execution

4 participants