Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for #268, few supported countries, and got rid of the bro… #269

Merged
merged 2 commits into from
Aug 7, 2022

Conversation

bodiam
Copy link
Contributor

@bodiam bodiam commented Aug 1, 2022

…ken password number generators (they iterated 10-100s of times for no reason)

…ken password number generators (they iterated 10-100s of times for no reason)
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #269 (c0291fb) into master (18d5dfc) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #269      +/-   ##
============================================
+ Coverage     94.37%   94.50%   +0.13%     
+ Complexity     1883     1864      -19     
============================================
  Files           195      193       -2     
  Lines          3819     3770      -49     
  Branches        391      379      -12     
============================================
- Hits           3604     3563      -41     
+ Misses          115      111       -4     
+ Partials        100       96       -4     
Impacted Files Coverage Δ
src/main/java/net/datafaker/Passport.java 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

…eration

# Conflicts:
#	src/test/java/net/datafaker/integration/FakerIntegrationTest.java
@bodiam bodiam merged commit f2a569e into master Aug 7, 2022
@bodiam bodiam deleted the passport_number_generation branch August 7, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants