Partial fix for #268, few supported countries, and got rid of the bro…#269
Merged
Conversation
…ken password number generators (they iterated 10-100s of times for no reason)
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
============================================
+ Coverage 94.37% 94.50% +0.13%
+ Complexity 1883 1864 -19
============================================
Files 195 193 -2
Lines 3819 3770 -49
Branches 391 379 -12
============================================
- Hits 3604 3563 -41
+ Misses 115 111 -4
+ Partials 100 96 -4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…eration # Conflicts: # src/test/java/net/datafaker/integration/FakerIntegrationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ken password number generators (they iterated 10-100s of times for no reason)