Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed IT test to Test. There's no need for integration tests. Relat… #270

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

bodiam
Copy link
Contributor

@bodiam bodiam commented Aug 1, 2022

…ed to issue #250

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #270 (54f51c6) into master (94d9955) will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #270      +/-   ##
============================================
+ Coverage     94.26%   94.57%   +0.31%     
- Complexity     1881     1890       +9     
============================================
  Files           195      195              
  Lines          3819     3819              
  Branches        391      391              
============================================
+ Hits           3600     3612      +12     
+ Misses          117      105      -12     
  Partials        102      102              
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.92% <100.00%> (+0.60%) ⬆️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️
src/main/java/net/datafaker/Code.java 95.40% <0.00%> (-2.30%) ⬇️
src/main/java/net/datafaker/Internet.java 90.41% <0.00%> (+1.36%) ⬆️
src/main/java/net/datafaker/Address.java 97.14% <0.00%> (+2.85%) ⬆️
src/main/java/net/datafaker/Commerce.java 100.00% <0.00%> (+4.00%) ⬆️
src/main/java/net/datafaker/IdNumber.java 100.00% <0.00%> (+6.66%) ⬆️
src/main/java/net/datafaker/Lorem.java 97.91% <0.00%> (+8.33%) ⬆️
...ava/net/datafaker/HitchhikersGuideToTheGalaxy.java 100.00% <0.00%> (+11.11%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@snuyanzin snuyanzin force-pushed the no_more_integration_tests branch from d88371d to 54f51c6 Compare August 1, 2022 15:45
@bodiam bodiam merged commit f6e1238 into master Aug 1, 2022
@bodiam bodiam deleted the no_more_integration_tests branch September 11, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants