Make concurrent tests more stable #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=========================================
Coverage 94.63% 94.63%
Complexity 1891 1891
=========================================
Files 195 195
Lines 3819 3819
Branches 391 391
=========================================
Hits 3614 3614
Misses 104 104
Partials 101 101
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Hi @snuyanzin , I got rid of all that code here : |
|
@bodiam |
|
@snuyanzin I saw that indeed, but I didn't look into a solution for that yet. Seems it's still failing? |
snuyanzin
changed the title
|
At least now it seems more stable: I scheduled it 5 times in a row for the latest commit in this PR and they are still green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strange thing about passports is that it generates something strange and then in a loop tries to check if the result of generation is ok or not.For instance, in
net.datafaker.passportnumbers.ChPassportNumber#getValidChit tries to generates something with regex[A-Z][0-9A-Z][0-9]{7}and then checks result againstE\\d\\d{7}andG\\d{8}. It is much faster to generate based on expected data.Update fix concurrent issue at https://github.com/datafaker-net/datafaker/runs/7640952734?check_suite_focus=true