Skip to content

Stabilize build for the case of concurrent tests#275

Merged
snuyanzin merged 1 commit into
datafaker-net:masterfrom
snuyanzin:testAllMethodsThatReturnStringsActuallyReturnStrings
Aug 22, 2022
Merged

Stabilize build for the case of concurrent tests#275
snuyanzin merged 1 commit into
datafaker-net:masterfrom
snuyanzin:testAllMethodsThatReturnStringsActuallyReturnStrings

Conversation

@snuyanzin

@snuyanzin snuyanzin commented Aug 4, 2022

Copy link
Copy Markdown
Collaborator

Make mapOfMethodAndCoercedArgs non static to avoid concurrency issues
add description for tests
Stabilize build for the case of concurrent tests

@codecov-commenter

codecov-commenter commented Aug 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #275 (d4a6f93) into master (2265045) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #275   +/-   ##
=========================================
  Coverage     94.89%   94.89%           
  Complexity     1911     1911           
=========================================
  Files           200      200           
  Lines          3817     3817           
  Branches        379      379           
=========================================
  Hits           3622     3622           
  Misses           99       99           
  Partials         96       96           
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.92% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin force-pushed the testAllMethodsThatReturnStringsActuallyReturnStrings branch from 4e15e35 to 2a19afd Compare August 11, 2022 15:45
@snuyanzin snuyanzin force-pushed the testAllMethodsThatReturnStringsActuallyReturnStrings branch 4 times, most recently from 43bd119 to 8e21f8d Compare August 22, 2022 18:49
@snuyanzin snuyanzin changed the title Set mapOfMethodAndCoercedArgs to non static, add description for test… Stabilize build for the case of concurrent tests Aug 22, 2022
@snuyanzin

Copy link
Copy Markdown
Collaborator Author

ok, now there are 20 successful builds in a row https://github.com/datafaker-net/datafaker/actions/runs/2906808090

@snuyanzin snuyanzin force-pushed the testAllMethodsThatReturnStringsActuallyReturnStrings branch 5 times, most recently from 503bebd to 7c39738 Compare August 22, 2022 22:09
@snuyanzin snuyanzin force-pushed the testAllMethodsThatReturnStringsActuallyReturnStrings branch from 7c39738 to d4a6f93 Compare August 22, 2022 22:18
@snuyanzin snuyanzin merged commit d4a6f93 into datafaker-net:master Aug 22, 2022
@bodiam

bodiam commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

ok, now there are 20 successful builds in a row https://github.com/datafaker-net/datafaker/actions/runs/2906808090

Awesome, thanks for your work on this. Let's hope this was the final bit.

@snuyanzin

Copy link
Copy Markdown
Collaborator Author

probably this change was the most important
https://github.com/datafaker-net/datafaker/pull/275/files#diff-ee97fe2f9fc8eaa7521b384156ad4c142059c3bb6f692e1698067aafc647f55bL36-R36

I didn't expect that in currency_code for uk there could be empty value and from another side a mandatory check for absence of empty currency codes...

@bodiam

bodiam commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

The heck :) that's weird indeed. You'd think by now most of the crazy parts are gone, but seems there's still some hidden gems in the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants