Error when generation passport without specifying locale

[panilya]

There is "passport.valid resulted in null expression" error when generating passport number without specifying Locale.

Edit:
There is Locale.ENGLISH - public static final Locale ENGLISH = createConstant("en", ""); without specifying country and there is Locale.US - public static final Locale US = createConstant("en", "US");. Datafaker uses Locale.ENGLISH and there are a lot of problems involving this choice, for example: incorrect resolving of phone_number formats. When changing Faker to Locale.US everything works fine. Should I change default Locale to Locale.US in Faker?

[bodiam]

Hmm, if you change the default locale, not a single test breaks? Cause if that's the case, I'd say go for it

[panilya]

This change has side effects, so I will not change the default locale to Locale.US.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.78%. Comparing base (fd06c1f) to head (70785cf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #282      +/-   ##
============================================
- Coverage     94.83%   94.78%   -0.06%     
+ Complexity     1879     1878       -1     
============================================
  Files           194      194              
  Lines          3777     3777              
  Branches        379      379              
============================================
- Hits           3582     3580       -2     
- Misses           99      100       +1     
- Partials         96       97       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[panilya]

@bodiam Now it seems okay, is it a good approach to solve this bug?

[bodiam]

I think so, I see no issue with this, and it's much better than what we had before, so let's use this.